From: Chris Lattner <sabre@nondot.org>
Date: Sun, 22 Nov 2009 16:16:48 +0000 (+0000)
Subject: add fixme for dubious code.  Duncan, what do you think?
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=6c7276f17eca3dcbceed46dc70a833153cfc581f;p=oota-llvm.git

add fixme for dubious code.  Duncan, what do you think?


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@89602 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Analysis/BasicAliasAnalysis.cpp b/lib/Analysis/BasicAliasAnalysis.cpp
index 45f5d40bd70..d366a50274a 100644
--- a/lib/Analysis/BasicAliasAnalysis.cpp
+++ b/lib/Analysis/BasicAliasAnalysis.cpp
@@ -263,6 +263,7 @@ ImmutablePass *llvm::createBasicAliasAnalysisPass() {
 bool BasicAliasAnalysis::pointsToConstantMemory(const Value *P) {
   if (const GlobalVariable *GV = 
         dyn_cast<GlobalVariable>(P->getUnderlyingObject()))
+    // FIXME: shouldn't this require GV to be "ODR"?
     return GV->isConstant();
   return false;
 }