From: Jo-Philipp Wich Date: Thu, 26 Jan 2017 09:13:23 +0000 (+0100) Subject: imagebuilder: properly escape single quotes in device titles X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=6cb8e30837ce1bfff8c3c4e18bc8ccf8b4c2c8d5;p=lede.git imagebuilder: properly escape single quotes in device titles The name "Plat'Home OpenBlocks AX3" causes the imagebuilders "make info" command to fail with: bash: -c: line 0: syntax error near unexpected token `(' bash: -c: line 0: `echo; [...]' Makefile:99: recipe for target '_call_info' failed Properly escape single quotes to avoid breaking the echo commands. Signed-off-by: Jo-Philipp Wich --- diff --git a/target/imagebuilder/files/Makefile b/target/imagebuilder/files/Makefile index 493012ff72..af633b2163 100644 --- a/target/imagebuilder/files/Makefile +++ b/target/imagebuilder/files/Makefile @@ -74,7 +74,7 @@ include $(INCLUDE_DIR)/target.mk USER_PROFILE ?= $(firstword $(PROFILE_NAMES)) PROFILE_LIST = $(foreach p,$(PROFILE_NAMES), \ - echo '$(patsubst DEVICE_%,%,$(p)):'; $(if $($(p)_NAME),echo ' $($(p)_NAME)'; ) echo ' Packages: $($(p)_PACKAGES)'; \ + echo '$(patsubst DEVICE_%,%,$(p)):'; $(if $($(p)_NAME),echo ' $(subst ','"'"',$($(p)_NAME))'; ) echo ' Packages: $($(p)_PACKAGES)'; \ ) .profiles.mk: .targetinfo