From: Axel Lin Date: Sat, 2 Aug 2014 05:36:38 +0000 (+0800) Subject: hwmon: (gpio-fan) Prevent overflow problem when writing large limits X-Git-Tag: firefly_0821_release~3679^2~1658 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=6dbbe154751f97308e0cd029f0b15f7685897ecf;p=firefly-linux-kernel-4.4.55.git hwmon: (gpio-fan) Prevent overflow problem when writing large limits commit 2565fb05d1e9fc0831f7b1c083bcfcb1cba1f020 upstream. On platforms with sizeof(int) < sizeof(unsigned long), writing a rpm value larger than MAXINT will result in unpredictable limit values written to the chip. Avoid auto-conversion from unsigned long to int to fix the problem. Signed-off-by: Axel Lin Signed-off-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/hwmon/gpio-fan.c b/drivers/hwmon/gpio-fan.c index 3104149795c5..ce1d82762ba6 100644 --- a/drivers/hwmon/gpio-fan.c +++ b/drivers/hwmon/gpio-fan.c @@ -172,7 +172,7 @@ static int get_fan_speed_index(struct gpio_fan_data *fan_data) return -EINVAL; } -static int rpm_to_speed_index(struct gpio_fan_data *fan_data, int rpm) +static int rpm_to_speed_index(struct gpio_fan_data *fan_data, unsigned long rpm) { struct gpio_fan_speed *speed = fan_data->speed; int i;