From: Tim Gardner Date: Tue, 23 Feb 2010 13:55:21 +0000 (+0100) Subject: netfilter: xt_recent: fix buffer overflow X-Git-Tag: firefly_0821_release~10186^2~2075 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=6f2deb6aad5e242d5573ae8d98a90a454f5e79d0;p=firefly-linux-kernel-4.4.55.git netfilter: xt_recent: fix buffer overflow commit 2c08522e5d2f0af2d6f05be558946dcbf8173683 upstream. e->index overflows e->stamps[] every ip_pkt_list_tot packets. Consider the case when ip_pkt_list_tot==1; the first packet received is stored in e->stamps[0] and e->index is initialized to 1. The next received packet timestamp is then stored at e->stamps[1] in recent_entry_update(), a buffer overflow because the maximum e->stamps[] index is 0. Signed-off-by: Tim Gardner Signed-off-by: Patrick McHardy Signed-off-by: Greg Kroah-Hartman --- diff --git a/net/netfilter/xt_recent.c b/net/netfilter/xt_recent.c index eb0ceb846527..d940a6367c7a 100644 --- a/net/netfilter/xt_recent.c +++ b/net/netfilter/xt_recent.c @@ -173,10 +173,10 @@ recent_entry_init(struct recent_table *t, const union nf_inet_addr *addr, static void recent_entry_update(struct recent_table *t, struct recent_entry *e) { + e->index %= ip_pkt_list_tot; e->stamps[e->index++] = jiffies; if (e->index > e->nstamps) e->nstamps = e->index; - e->index %= ip_pkt_list_tot; list_move_tail(&e->lru_list, &t->lru_list); }