From: bsimmers <bsimmers@fb.com>
Date: Sat, 5 Oct 2013 02:46:40 +0000 (-0700)
Subject: Turn one more folly::format error into a fatal
X-Git-Tag: v0.22.0~835
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=6f3352378fe7effd50c2b7496f11348f27449977;p=folly.git

Turn one more folly::format error into a fatal

Summary:
I missed this one in my original diff. It's a static property of the
format string and the number of arguments passed.

Test Plan:
automated tests. saw that my buggy format() call aborted instead of throwing an
exception

Reviewed By: andrei.alexandrescu@fb.com

FB internal diff: D998409
@override-unit-failures
---

diff --git a/folly/Format.h b/folly/Format.h
index 79a4e705..c4e18f75 100644
--- a/folly/Format.h
+++ b/folly/Format.h
@@ -121,7 +121,7 @@ class Formatter {
   template <size_t K, class Callback>
   typename std::enable_if<K == valueCount>::type
   doFormatFrom(size_t i, FormatArg& arg, Callback& cb) const {
-    arg.error("argument index out of range, max=", i);
+    LOG(FATAL) << arg.errorStr("argument index out of range, max=", i);
   }
 
   template <size_t K, class Callback>