From: Chanwoo Choi Date: Mon, 27 Jun 2016 10:17:06 +0000 (+0900) Subject: UPSTREAM: extcon: Move struct extcon_cable from header file to core X-Git-Tag: firefly_0821_release~2022 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=70eed11ebb463b831590c0a8f7c4a96bbfbe56e5;p=firefly-linux-kernel-4.4.55.git UPSTREAM: extcon: Move struct extcon_cable from header file to core This patch moves the struct extcon_cable because that should be only handled by extcon core. There are no reason to publish the internal structure. Change-Id: I7b2e68487ad0ddfa8a2342e7754f16af8623aa58 Signed-off-by: Chanwoo Choi Signed-off-by: Chris Zhong (cherry picked from commit 20f7b53dfc24e0caa984087691af82e442229680) --- diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 3c3bdc0c2aa9..7538a0ac7eed 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -77,6 +77,26 @@ static const char *extcon_name[] = { NULL, }; +/** + * struct extcon_cable - An internal data for each cable of extcon device. + * @edev: The extcon device + * @cable_index: Index of this cable in the edev + * @attr_g: Attribute group for the cable + * @attr_name: "name" sysfs entry + * @attr_state: "state" sysfs entry + * @attrs: Array pointing to attr_name and attr_state for attr_g + */ +struct extcon_cable { + struct extcon_dev *edev; + int cable_index; + + struct attribute_group attr_g; + struct device_attribute attr_name; + struct device_attribute attr_state; + + struct attribute *attrs[3]; /* to be fed to attr_g.attrs */ +}; + static struct class *extcon_class; #if defined(CONFIG_ANDROID) static struct class_compat *switch_class; diff --git a/include/linux/extcon.h b/include/linux/extcon.h index cec5c543afc6..1b2c8b6809cc 100644 --- a/include/linux/extcon.h +++ b/include/linux/extcon.h @@ -126,26 +126,6 @@ struct extcon_dev { struct device_attribute *d_attrs_muex; }; -/** - * struct extcon_cable - An internal data for each cable of extcon device. - * @edev: The extcon device - * @cable_index: Index of this cable in the edev - * @attr_g: Attribute group for the cable - * @attr_name: "name" sysfs entry - * @attr_state: "state" sysfs entry - * @attrs: Array pointing to attr_name and attr_state for attr_g - */ -struct extcon_cable { - struct extcon_dev *edev; - int cable_index; - - struct attribute_group attr_g; - struct device_attribute attr_name; - struct device_attribute attr_state; - - struct attribute *attrs[3]; /* to be fed to attr_g.attrs */ -}; - #if IS_ENABLED(CONFIG_EXTCON) /*