From: Maarten Lankhorst Date: Tue, 29 Jan 2013 16:52:24 +0000 (+0100) Subject: x86, efi: remove attribute check from setup_efi_pci X-Git-Tag: firefly_0821_release~3680^2~1183^2^2 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=739701888f5d98010a8960b2d974d74c77c830a2;p=firefly-linux-kernel-4.4.55.git x86, efi: remove attribute check from setup_efi_pci It looks like the original commit that copied the rom contents from efi always copied the rom, and the fixup in setup_efi_pci from commit 886d751a2ea99a160 ("x86, efi: correct precedence of operators in setup_efi_pci") broke that. This resulted in macbook pro's no longer finding the rom images, and thus not being able to use the radeon card any more. The solution is to just remove the check for now, and always copy the rom if available. Reported-by: Vitaly Budovski Cc: Dan Carpenter Cc: Seth Forshee Acked-by: Matthew Garrett Cc: Bjorn Helgaas Cc: Sasha Levin Signed-off-by: Maarten Lankhorst Signed-off-by: Matt Fleming --- diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c index 3f3d36f5a800..b0098ba4f23b 100644 --- a/arch/x86/boot/compressed/eboot.c +++ b/arch/x86/boot/compressed/eboot.c @@ -302,9 +302,6 @@ static efi_status_t setup_efi_pci(struct boot_params *params) if (status != EFI_SUCCESS) continue; - if (!(attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM)) - continue; - if (!pci->romimage || !pci->romsize) continue;