From: Chris Boot Date: Wed, 15 Feb 2012 14:59:09 +0000 (+0000) Subject: firewire: sbp2: Ignore SBP-2 targets on the local node X-Git-Tag: firefly_0821_release~3680^2~3288^2~13 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=74044563a2318f2c56fa53af64f7800f49fb479d;p=firefly-linux-kernel-4.4.55.git firewire: sbp2: Ignore SBP-2 targets on the local node The firewire-sbp2 module tries to login to an SBP-2/3 target even when it is running on the local node, which fails because of the inability to fetch data from DMA mapped regions using firewire transactions on the local node. It also doesn't make much sense to have the initiator and target on the same node, so this patch prevents this behaviour. Signed-off-by: Chris Boot Signed-off-by: Stefan Richter (changed the comment) --- diff --git a/drivers/firewire/sbp2.c b/drivers/firewire/sbp2.c index 4865d641329a..0c92ed835e06 100644 --- a/drivers/firewire/sbp2.c +++ b/drivers/firewire/sbp2.c @@ -1141,6 +1141,10 @@ static int sbp2_probe(struct device *dev) struct Scsi_Host *shost; u32 model, firmware_revision; + /* cannot (or should not) handle targets on the local node */ + if (device->is_local) + return -ENODEV; + if (dma_get_max_seg_size(device->card->device) > SBP2_MAX_SEG_SIZE) BUG_ON(dma_set_max_seg_size(device->card->device, SBP2_MAX_SEG_SIZE));