From: Andrew Morton Date: Thu, 3 Apr 2014 21:49:29 +0000 (-0700) Subject: scripts/checkpatch.pl: __GFP_NOFAIL isn't going away X-Git-Tag: firefly_0821_release~176^2~4160^2~75 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=74915c7dd0e144cc735058a77a3901c98f1e7039;p=firefly-linux-kernel-4.4.55.git scripts/checkpatch.pl: __GFP_NOFAIL isn't going away Revert commit 7e4915e78992 ("checkpatch: add warning of future __GFP_NOFAIL use"). There are no plans to remove __GFP_NOFAIL. __GFP_NOFAIL exists to a) centralise the retry-allocation-for-ever operation into the core allocator, which is the appropriate implementation site and b) permit us to identify code sites which aren't handling memory exhaustion appropriately. Cc: David Rientjes Cc: Joe Perches Cc: Theodore Ts'o Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 33072d6c1b5a..d9b09eb767bb 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -4330,12 +4330,6 @@ sub process { "$1 uses number as first arg, sizeof is generally wrong\n" . $herecurr); } -# check for GFP_NOWAIT use - if ($line =~ /\b__GFP_NOFAIL\b/) { - WARN("__GFP_NOFAIL", - "Use of __GFP_NOFAIL is deprecated, no new users should be added\n" . $herecurr); - } - # check for multiple semicolons if ($line =~ /;\s*;\s*$/) { if (WARN("ONE_SEMICOLON",