From: Jakub Staszak Date: Tue, 16 Oct 2012 19:32:31 +0000 (+0000) Subject: Simplify potentially quadratic behavior while erasing elements from std::vector. X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=761fbec9c2ace70c12cf41f5d0e97c42a303eeb9;p=oota-llvm.git Simplify potentially quadratic behavior while erasing elements from std::vector. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166045 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Transforms/Scalar/DCE.cpp b/lib/Transforms/Scalar/DCE.cpp index 086f0a1a714..8d53443b389 100644 --- a/lib/Transforms/Scalar/DCE.cpp +++ b/lib/Transforms/Scalar/DCE.cpp @@ -118,13 +118,7 @@ bool DCE::runOnFunction(Function &F) { I->eraseFromParent(); // Remove the instruction from the worklist if it still exists in it. - for (std::vector::iterator WI = WorkList.begin(); - WI != WorkList.end(); ) { - if (*WI == I) - WI = WorkList.erase(WI); - else - ++WI; - } + WorkList.erase(std::remove(WorkList.begin(), WorkList.end(), I), WorkList.end()); MadeChange = true; ++DCEEliminated;