From: Rusty Russell Date: Thu, 7 Aug 2014 13:08:55 +0000 (+0930) Subject: arch/powerpc/platforms/powernv/opal-dump.c: fix world-writable sysfs files X-Git-Tag: firefly_0821_release~176^2~3416^2 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=76215b04fd297c008b91ece732ed36e67e0181fa;p=firefly-linux-kernel-4.4.55.git arch/powerpc/platforms/powernv/opal-dump.c: fix world-writable sysfs files If you don't have a store function, you're not writable anyway! Signed-off-by: Rusty Russell --- diff --git a/arch/powerpc/platforms/powernv/opal-dump.c b/arch/powerpc/platforms/powernv/opal-dump.c index 788a1977b9a5..85bb8fff7947 100644 --- a/arch/powerpc/platforms/powernv/opal-dump.c +++ b/arch/powerpc/platforms/powernv/opal-dump.c @@ -102,9 +102,9 @@ static ssize_t dump_ack_store(struct dump_obj *dump_obj, * due to the dynamic size of the dump */ static struct dump_attribute id_attribute = - __ATTR(id, 0666, dump_id_show, NULL); + __ATTR(id, S_IRUGO, dump_id_show, NULL); static struct dump_attribute type_attribute = - __ATTR(type, 0666, dump_type_show, NULL); + __ATTR(type, S_IRUGO, dump_type_show, NULL); static struct dump_attribute ack_attribute = __ATTR(acknowledge, 0660, dump_ack_show, dump_ack_store);