From: Christopher Dykes Date: Tue, 26 Jul 2016 22:53:04 +0000 (-0700) Subject: Don't run the thread local tests requiring dlopen on Windows X-Git-Tag: v2016.07.29.00~11 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=76551ae88ffd2588d05d94814af75c489d1454f7;p=folly.git Don't run the thread local tests requiring dlopen on Windows Summary: When I initially added the surrounding `#ifdef` I failed at where I put my `#endif`, as I left the shared library test enabled. This disables it for Windows. Reviewed By: yfeldblum Differential Revision: D3622769 fbshipit-source-id: f263201239095bbef076300d5f40649ebee1173c --- diff --git a/folly/test/ThreadLocalTest.cpp b/folly/test/ThreadLocalTest.cpp index e836ef37..e2e2fce0 100644 --- a/folly/test/ThreadLocalTest.cpp +++ b/folly/test/ThreadLocalTest.cpp @@ -575,7 +575,6 @@ TEST(ThreadLocal, Fork2) { EXPECT_TRUE(false) << "fork failed"; } } -#endif // Elide this test when using any sanitizer. Otherwise, the dlopen'ed code // would end up running without e.g., ASAN-initialized data structures and @@ -624,6 +623,7 @@ TEST(ThreadLocal, SharedLibrary) { t2.join(); } +#endif #endif namespace folly { namespace threadlocal_detail {