From: Al Viro <viro@zeniv.linux.org.uk>
Date: Sat, 18 Mar 2006 18:22:53 +0000 (-0500)
Subject: [PATCH] stop leaking cfq_data in cfq_set_request()
X-Git-Tag: firefly_0821_release~37610^2~14
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=7670876d2d194b2aecb54f397704838eee7d72ee;p=firefly-linux-kernel-4.4.55.git

[PATCH] stop leaking cfq_data in cfq_set_request()

We don't need to pin ->key down; ->cfqq->cfqd will do that for us.
Incidentally, that stops the leak we had - that reference was never
dropped.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---

diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index 37a2a772498c..63ed11f8795d 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -1433,7 +1433,6 @@ cfq_get_io_context(struct cfq_data *cfqd, pid_t pid, gfp_t gfp_mask)
 		ioc->set_ioprio = cfq_ioc_set_ioprio;
 		cic->ioc = ioc;
 		cic->key = cfqd;
-		atomic_inc(&cfqd->ref);
 	} else {
 		struct cfq_io_context *__cic;
 
@@ -1469,7 +1468,6 @@ cfq_get_io_context(struct cfq_data *cfqd, pid_t pid, gfp_t gfp_mask)
 
 		__cic->ioc = ioc;
 		__cic->key = cfqd;
-		atomic_inc(&cfqd->ref);
 		list_add(&__cic->list, &cic->list);
 		cic = __cic;
 	}