From: Anton Korobeynikov Date: Wed, 9 Jul 2008 21:54:26 +0000 (+0000) Subject: Remove a FIXME: we really need to use const_data section on darwin for X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=7705ea33e4898c6d7718f0a2dab22d6659498fc4;p=oota-llvm.git Remove a FIXME: we really need to use const_data section on darwin for constant pool, if relocation model is not static. This directly maps to the way how GCC works. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@53370 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Target/X86/X86TargetAsmInfo.cpp b/lib/Target/X86/X86TargetAsmInfo.cpp index 87024a8c171..d7438607559 100644 --- a/lib/Target/X86/X86TargetAsmInfo.cpp +++ b/lib/Target/X86/X86TargetAsmInfo.cpp @@ -139,9 +139,10 @@ X86DarwinTargetAsmInfo::X86DarwinTargetAsmInfo(const X86TargetMachine &TM): PrivateGlobalPrefix = "L"; // Marker for constant pool idxs BSSSection = 0; // no BSS section. ZeroFillDirective = "\t.zerofill\t"; // Uses .zerofill - // FIXME: It seems, this should be .const_data if relocation model is not - // static. - ConstantPoolSection = "\t.const\n"; + if (X86TM->getRelocationModel() != Reloc::Static) + ConstantPoolSection = "\t.const_data"; + else + ConstantPoolSection = "\t.const\n"; JumpTableDataSection = "\t.const\n"; CStringSection = "\t.cstring"; CStringSection_ = getUnnamedSection("\t.cstring",