From: Dan Carpenter Date: Tue, 13 Oct 2015 07:11:09 +0000 (+0300) Subject: ASoC: es8328: harmless underflow in es8328_put_deemph() X-Git-Tag: firefly_0821_release~176^2~581^2~9^2^4~8^3 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=7ab8a54ea7914574c04c0ac441f9ab65ff21abd9;p=firefly-linux-kernel-4.4.55.git ASoC: es8328: harmless underflow in es8328_put_deemph() Valid values for "deemph" are zero and one but we accidentally allow negative values as well. It's harmless but it causes static checker warnings and we may as well clean it up. Signed-off-by: Dan Carpenter Signed-off-by: Mark Brown --- diff --git a/sound/soc/codecs/es8328.c b/sound/soc/codecs/es8328.c index 6a091016e0fc..969e337dc17c 100644 --- a/sound/soc/codecs/es8328.c +++ b/sound/soc/codecs/es8328.c @@ -129,7 +129,7 @@ static int es8328_put_deemph(struct snd_kcontrol *kcontrol, { struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol); struct es8328_priv *es8328 = snd_soc_codec_get_drvdata(codec); - int deemph = ucontrol->value.integer.value[0]; + unsigned int deemph = ucontrol->value.integer.value[0]; int ret; if (deemph > 1)