From: Giuseppe Ottaviano Date: Thu, 22 Sep 2016 18:06:31 +0000 (-0700) Subject: Fix a couple comments X-Git-Tag: v2016.09.26.00~3 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=7c05f8aff907815f30bce0053411a1c181baadc2;p=folly.git Fix a couple comments Reviewed By: nbronson Differential Revision: D3905865 fbshipit-source-id: 2743af4ae1b34adb0f8e611e672f9b6068430ec9 --- diff --git a/folly/AtomicHashArray.h b/folly/AtomicHashArray.h index 3269a01e..2a02f1a5 100644 --- a/folly/AtomicHashArray.h +++ b/folly/AtomicHashArray.h @@ -16,8 +16,8 @@ /** * AtomicHashArray is the building block for AtomicHashMap. It provides the - * core lock-free functionality, but is limitted by the fact that it cannot - * grow past it's initialization size and is a little more awkward (no public + * core lock-free functionality, but is limited by the fact that it cannot + * grow past its initialization size and is a little more awkward (no public * constructor, for example). If you're confident that you won't run out of * space, don't mind the awkardness, and really need bare-metal performance, * feel free to use AHA directly. diff --git a/folly/AtomicHashMap.h b/folly/AtomicHashMap.h index b4a0563e..e1ef81a0 100644 --- a/folly/AtomicHashMap.h +++ b/folly/AtomicHashMap.h @@ -17,7 +17,7 @@ /* * AtomicHashMap -- * - * A high performance concurrent hash map with int32 or int64 keys. Supports + * A high-performance concurrent hash map with int32 or int64 keys. Supports * insert, find(key), findAt(index), erase(key), size, and more. Memory cannot * be freed or reclaimed by erase. Can grow to a maximum of about 18 times the * initial capacity, but performance degrades linearly with growth. Can also be @@ -25,7 +25,7 @@ * internal storage (retrieved with iterator::getIndex()). * * Advantages: - * - High performance (~2-4x tbb::concurrent_hash_map in heavily + * - High-performance (~2-4x tbb::concurrent_hash_map in heavily * multi-threaded environments). * - Efficient memory usage if initial capacity is not over estimated * (especially for small keys and values). @@ -56,7 +56,7 @@ * faster because of reduced data indirection. * * AHMap is a wrapper around AHArray sub-maps that allows growth and provides - * an interface closer to the stl UnorderedAssociativeContainer concept. These + * an interface closer to the STL UnorderedAssociativeContainer concept. These * sub-maps are allocated on the fly and are processed in series, so the more * there are (from growing past initial capacity), the worse the performance. * diff --git a/folly/SharedMutex.h b/folly/SharedMutex.h index aa5639e2..24bce0d7 100644 --- a/folly/SharedMutex.h +++ b/folly/SharedMutex.h @@ -204,11 +204,11 @@ // // If you have observed by profiling that your SharedMutex-s are getting // cache misses on deferredReaders[] due to another SharedMutex user, then -// you can use the tag type plus the RWDEFERREDLOCK_DECLARE_STATIC_STORAGE -// macro to create your own instantiation of the type. The contention -// threshold (see kNumSharedToStartDeferring) should make this unnecessary -// in all but the most extreme cases. Make sure to check that the -// increased icache and dcache footprint of the tagged result is worth it. +// you can use the tag type to create your own instantiation of the type. +// The contention threshold (see kNumSharedToStartDeferring) should make +// this unnecessary in all but the most extreme cases. Make sure to check +// that the increased icache and dcache footprint of the tagged result is +// worth it. // SharedMutex's use of thread local storage is as an optimization, so // for the case where thread local storage is not supported, define it