From: Andrey Vagin Date: Tue, 9 Sep 2014 21:51:06 +0000 (-0700) Subject: fs/notify: don't show f_handle if exportfs_encode_inode_fh failed X-Git-Tag: firefly_0821_release~176^2~3258^2 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=7e8824816bda16bb11ff5ff1e1212d642e57b0b3;p=firefly-linux-kernel-4.4.55.git fs/notify: don't show f_handle if exportfs_encode_inode_fh failed Currently we handle only ENOSPC. In case of other errors the file_handle variable isn't filled properly and we will show a part of stack. Signed-off-by: Andrey Vagin Acked-by: Cyrill Gorcunov Cc: Alexander Viro Cc: Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/fs/notify/fdinfo.c b/fs/notify/fdinfo.c index 660d33bc1bef..9d7e2b9659cb 100644 --- a/fs/notify/fdinfo.c +++ b/fs/notify/fdinfo.c @@ -50,7 +50,7 @@ static int show_mark_fhandle(struct seq_file *m, struct inode *inode) size = f.handle.handle_bytes >> 2; ret = exportfs_encode_inode_fh(inode, (struct fid *)f.handle.f_handle, &size, 0); - if ((ret == FILEID_INVALID) || (ret == -ENOSPC)) { + if ((ret == FILEID_INVALID) || (ret < 0)) { WARN_ONCE(1, "Can't encode file handler for inotify: %d\n", ret); return 0; }