From: Dan Carpenter <error27@gmail.com>
Date: Thu, 10 Jun 2010 07:53:05 +0000 (+0200)
Subject: [SCSI] be2iscsi: fix null dereference on error path
X-Git-Tag: firefly_0821_release~9833^2~1305^2~215
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=82284c09c5dc5c5a5046f3c852f2683dab60109c;p=firefly-linux-kernel-4.4.55.git

[SCSI] be2iscsi: fix null dereference on error path

"phba" is always null here so we can't dereference it.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
---

diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index 353a90b3574d..0d35bf6c6acc 100644
--- a/drivers/scsi/be2iscsi/be_main.c
+++ b/drivers/scsi/be2iscsi/be_main.c
@@ -3774,8 +3774,8 @@ static int __devinit beiscsi_dev_probe(struct pci_dev *pcidev,
 
 	ret = beiscsi_enable_pci(pcidev);
 	if (ret < 0) {
-		shost_printk(KERN_ERR, phba->shost, "beiscsi_dev_probe-"
-			     "Failed to enable pci device \n");
+		dev_err(&pcidev->dev, "beiscsi_dev_probe-"
+			" Failed to enable pci device\n");
 		return ret;
 	}