From: Owen Anderson <resistor@mac.com>
Date: Thu, 26 Jun 2008 17:06:02 +0000 (+0000)
Subject: Don't create a whole new string just to copy the elements into it.
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=8342cfff9a221dd69c1d9c615414ec3b8c8db776;p=oota-llvm.git

Don't create a whole new string just to copy the elements into it.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@52785 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/CodeGen/MachineModuleInfo.cpp b/lib/CodeGen/MachineModuleInfo.cpp
index 1720745e445..60526643fdf 100644
--- a/lib/CodeGen/MachineModuleInfo.cpp
+++ b/lib/CodeGen/MachineModuleInfo.cpp
@@ -231,11 +231,9 @@ public:
   }
   virtual void Apply(std::string &Field) {
     Constant *C = CI->getOperand(I++);
-    std::string S;
-    if (GetConstantStringInfo(C, S))
-      Field = S;
-    else
-      Field = "";
+    // Fills in the string if it succeeds
+    if (!GetConstantStringInfo(C, Field))
+      Field.clear();
   }
   virtual void Apply(DebugInfoDesc *&Field) {
     Constant *C = CI->getOperand(I++);