From: Jesper Juhl Date: Mon, 30 Sep 2013 19:25:27 +0000 (+0200) Subject: isdn: eicon: free pointer after using it in log msg in divas_um_idi_delete_entity() X-Git-Tag: firefly_0821_release~176^2~4992^2~242 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=84557783c5574f436826d88cd1bd035f20a4427f;p=firefly-linux-kernel-4.4.55.git isdn: eicon: free pointer after using it in log msg in divas_um_idi_delete_entity() Not really a problem, but nice IMHO; the Coverity static analyzer complains that we use the pointer 'e' after it has been freed, so move the freeing below the final use, even if that use is just using the value of the pointer and not actually dereferencing it. Signed-off-by: Jesper Juhl Signed-off-by: David S. Miller --- diff --git a/drivers/isdn/hardware/eicon/um_idi.c b/drivers/isdn/hardware/eicon/um_idi.c index 7cab5c3276c2..e1519718ce67 100644 --- a/drivers/isdn/hardware/eicon/um_idi.c +++ b/drivers/isdn/hardware/eicon/um_idi.c @@ -288,9 +288,9 @@ int divas_um_idi_delete_entity(int adapter_nr, void *entity) cleanup_entity(e); diva_os_free(0, e->os_context); memset(e, 0x00, sizeof(*e)); - diva_os_free(0, e); DBG_LOG(("A(%d) remove E:%08x", adapter_nr, e)); + diva_os_free(0, e); return (0); }