From: Himangi Saraogi Date: Sat, 1 Mar 2014 21:31:17 +0000 (+0530) Subject: staging: lustre: remove assignment in if condition X-Git-Tag: firefly_0821_release~176^2~4193^2~612 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=8505e3fc47b37591c3189b6e49e3f3a01b36d753;p=firefly-linux-kernel-4.4.55.git staging: lustre: remove assignment in if condition This patch removes the assignment in if conditions to do away with the checkpatch warning :'do not use assignment in if condition'. Signed-off-by: Himangi Saraogi Reviewed-by: Paul E. McKenney Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/lustre/lustre/ptlrpc/gss/gss_krb5_mech.c b/drivers/staging/lustre/lustre/ptlrpc/gss/gss_krb5_mech.c index 6eda1799be8f..d03f6c114171 100644 --- a/drivers/staging/lustre/lustre/ptlrpc/gss/gss_krb5_mech.c +++ b/drivers/staging/lustre/lustre/ptlrpc/gss/gss_krb5_mech.c @@ -678,7 +678,8 @@ __s32 krb5_make_checksum(__u32 enctype, __u32 code = GSS_S_FAILURE; int rc; - if (!(tfm = ll_crypto_alloc_hash(ke->ke_hash_name, 0, 0))) { + tfm = ll_crypto_alloc_hash(ke->ke_hash_name, 0, 0); + if (!tfm) { CERROR("failed to alloc TFM: %s\n", ke->ke_hash_name); return GSS_S_FAILURE; }