From: Alexander Gordeev Date: Thu, 13 Jan 2011 01:00:49 +0000 (-0800) Subject: pps: declare variables where they are used in switch X-Git-Tag: firefly_0821_release~7613^2~2940 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=86d921f9ec06bc3fd357a77877d37a604d5674c3;p=firefly-linux-kernel-4.4.55.git pps: declare variables where they are used in switch Move variable declarations where they are used in pps_cdev_ioctl. Signed-off-by: Alexander Gordeev Acked-by: Rodolfo Giometti Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/drivers/pps/pps.c b/drivers/pps/pps.c index ca5183bdad85..c76afb980a98 100644 --- a/drivers/pps/pps.c +++ b/drivers/pps/pps.c @@ -61,8 +61,6 @@ static long pps_cdev_ioctl(struct file *file, { struct pps_device *pps = file->private_data; struct pps_kparams params; - struct pps_fdata fdata; - unsigned long ticks; void __user *uarg = (void __user *) arg; int __user *iuarg = (int __user *) arg; int err; @@ -136,7 +134,9 @@ static long pps_cdev_ioctl(struct file *file, break; - case PPS_FETCH: + case PPS_FETCH: { + struct pps_fdata fdata; + pr_debug("PPS_FETCH: source %d\n", pps->id); err = copy_from_user(&fdata, uarg, sizeof(struct pps_fdata)); @@ -149,6 +149,8 @@ static long pps_cdev_ioctl(struct file *file, if (fdata.timeout.flags & PPS_TIME_INVALID) err = wait_event_interruptible(pps->queue, pps->go); else { + unsigned long ticks; + pr_debug("timeout %lld.%09d\n", (long long) fdata.timeout.sec, fdata.timeout.nsec); @@ -185,7 +187,7 @@ static long pps_cdev_ioctl(struct file *file, return -EFAULT; break; - + } default: return -ENOTTY; break;