From: Chris Lattner Date: Fri, 20 Oct 2006 18:20:21 +0000 (+0000) Subject: Fix miscompilation of MallocBench/espresso which code review pointed out X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=87d8429506998806b9fe74cab7a16963ad4a088e;p=oota-llvm.git Fix miscompilation of MallocBench/espresso which code review pointed out but apparently didn't make it into the final patch. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@31070 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Transforms/Scalar/InstructionCombining.cpp b/lib/Transforms/Scalar/InstructionCombining.cpp index c30c0c924f8..bcb4888b6ae 100644 --- a/lib/Transforms/Scalar/InstructionCombining.cpp +++ b/lib/Transforms/Scalar/InstructionCombining.cpp @@ -4913,7 +4913,7 @@ Instruction *InstCombiner::visitShiftInst(ShiftInst &I) { // shr int -1, X = -1 (for any arithmetic shift rights of ~0) if (!isLeftShift) if (ConstantInt *CSI = dyn_cast(Op0)) - if (CSI->isAllOnesValue()) + if (CSI->isAllOnesValue() && Op0->getType()->isSigned()) return ReplaceInstUsesWith(I, CSI); // Try to fold constant and into select arguments.