From: David Howells <dhowells@redhat.com>
Date: Thu, 4 Apr 2013 15:44:51 +0000 (+0100)
Subject: nubus: Don't use create_proc_entry()
X-Git-Tag: firefly_0821_release~3680^2~611^2~92
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=8a25378e408022c441a1d27082fea9264323b7e7;p=firefly-linux-kernel-4.4.55.git

nubus: Don't use create_proc_entry()

Don't use create_proc_entry() in nubus_proc_subdir().  The files created aren't
given any way to use them, so for the moment use create_proc_read_entry() with
a NULL accessor and generate a compile-time warning.

Signed-off-by: David Howells <dhowells@redhat.com>
---

diff --git a/drivers/nubus/proc.c b/drivers/nubus/proc.c
index 208dd12825bc..bb1446bb2802 100644
--- a/drivers/nubus/proc.c
+++ b/drivers/nubus/proc.c
@@ -73,8 +73,9 @@ static void nubus_proc_subdir(struct nubus_dev* dev,
 		struct proc_dir_entry* e;
 		
 		sprintf(name, "%x", ent.type);
-		e = create_proc_entry(name, S_IFREG | S_IRUGO |
-				      S_IWUSR, parent);
+#warning Need to set some I/O handlers here
+		e = create_proc_read_entry(name, S_IFREG | S_IRUGO | S_IWUSR,
+					   parent, NULL, NULL);
 		if (!e) return;
 	}
 }