From: Sachin Kamat <sachin.kamat@linaro.org>
Date: Tue, 18 Feb 2014 10:41:05 +0000 (+0530)
Subject: regulator: da9063: Do not hardcode return values
X-Git-Tag: firefly_0821_release~176^2~4202^2~5^5~2
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=8a7963d55b58aa95f45928dec229380c28d921ed;p=firefly-linux-kernel-4.4.55.git

regulator: da9063: Do not hardcode return values

Propagate the error values returned by the function instead.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
---

diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c
index f5d1ca9ab7dd..3c65644f3007 100644
--- a/drivers/regulator/da9063-regulator.c
+++ b/drivers/regulator/da9063-regulator.c
@@ -363,7 +363,7 @@ static int da9063_set_suspend_voltage(struct regulator_dev *rdev, int uV)
 
 	sel = regulator_map_voltage_linear(rdev, uV, uV);
 	if (sel < 0)
-		return -EINVAL;
+		return sel;
 
 	sel <<= ffs(rdev->desc->vsel_mask) - 1;
 
@@ -755,7 +755,7 @@ static int da9063_regulator_probe(struct platform_device *pdev)
 	if (ret < 0) {
 		dev_err(&pdev->dev,
 			"Error while reading BUCKs configuration\n");
-		return -EIO;
+		return ret;
 	}
 	bcores_merged = val & DA9063_BCORE_MERGE;
 	bmem_bio_merged = val & DA9063_BUCK_MERGE;