From: Nicholas Ormrod Date: Thu, 30 Oct 2014 18:16:39 +0000 (-0700) Subject: Allow catch-int to be nolinted X-Git-Tag: v0.22.0~224 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=8b05be27769e2e3d5d1681251953506c22f76b45;p=folly.git Allow catch-int to be nolinted Summary: Add a hidden nolint option to suppress this lint warning. It is appropriate in this case. Test Plan: Build flint, run it on ExceptionWrapperTest.cpp, see no catch lint failure Reviewed By: andrei.alexandrescu@fb.com Subscribers: sdwilsh, louisk, njormrod, folly-diffs@ FB internal diff: D1644165 Tasks: 5486739 Signature: t1:1644165:1414616664:a6b9dc34660df84b33ed8faaf48ec048a02bad01 --- diff --git a/folly/test/ExceptionWrapperTest.cpp b/folly/test/ExceptionWrapperTest.cpp index 785ff13d..bfeac2bc 100644 --- a/folly/test/ExceptionWrapperTest.cpp +++ b/folly/test/ExceptionWrapperTest.cpp @@ -210,7 +210,7 @@ TEST(ExceptionWrapper, non_std_exception_test) { // access their value is to explicity rethrow and catch it. try { ew.throwException(); - } catch (int& i) { + } catch /* nolint */ (int& i) { EXPECT_EQ(i, expected); } }