From: Sakari Ailus Date: Wed, 25 Mar 2015 22:57:26 +0000 (-0300) Subject: [media] omap3isp: Avoid a BUG_ON() in media_entity_create_link() X-Git-Tag: firefly_0821_release~176^2~795^2~1267 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=8b3aff7cdd6c2e7c9a3df755b23525e393195102;p=firefly-linux-kernel-4.4.55.git [media] omap3isp: Avoid a BUG_ON() in media_entity_create_link() If an uninitialised v4l2_subdev struct was passed to media_entity_create_link(), one of the BUG_ON()'s in the function will be hit since media_entity.num_pads will be zero. Avoid this by checking whether the num_pads field is non-zero for the interface. Signed-off-by: Sakari Ailus Signed-off-by: Laurent Pinchart Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index fb193b65b5ce..4ab674dd43c1 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -1946,6 +1946,19 @@ static int isp_register_entities(struct isp_device *isp) goto done; } + /* + * Not all interfaces are available on all revisions + * of the ISP. The sub-devices of those interfaces + * aren't initialised in such a case. Check this by + * ensuring the num_pads is non-zero. + */ + if (!input->num_pads) { + dev_err(isp->dev, "%s: invalid input %u\n", + entity->name, subdevs->interface); + ret = -EINVAL; + goto done; + } + for (i = 0; i < sensor->entity.num_pads; i++) { if (sensor->entity.pads[i].flags & MEDIA_PAD_FL_SOURCE) break;