From: Takashi Iwai <tiwai@suse.de>
Date: Wed, 30 Oct 2013 17:40:04 +0000 (+0100)
Subject: ASoC: ml26124: Fix negative array index read
X-Git-Tag: firefly_0821_release~176^2~4889^2~33^2~25^2
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=8b4b30365ce6cefe4193f439ac7263bb2cdd66fd;p=firefly-linux-kernel-4.4.55.git

ASoC: ml26124: Fix negative array index read

get_coeff() may return an error.

Spotted by coverity CID 703394.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Mark Brown <broonie@linaro.org>
---

diff --git a/sound/soc/codecs/ml26124.c b/sound/soc/codecs/ml26124.c
index 26118828782b..185fa3bc3052 100644
--- a/sound/soc/codecs/ml26124.c
+++ b/sound/soc/codecs/ml26124.c
@@ -342,6 +342,8 @@ static int ml26124_hw_params(struct snd_pcm_substream *substream,
 	struct ml26124_priv *priv = snd_soc_codec_get_drvdata(codec);
 	int i = get_coeff(priv->mclk, params_rate(hw_params));
 
+	if (i < 0)
+		return i;
 	priv->substream = substream;
 	priv->rate = params_rate(hw_params);