From: Dan Carpenter Date: Wed, 17 Apr 2013 06:20:30 +0000 (-0300) Subject: [media] go7007: dubious one-bit signed bitfields X-Git-Tag: firefly_0821_release~176^2~3573^2~1998 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=8c93c40080bda655295ae3673dfb26dee34d9d49;p=firefly-linux-kernel-4.4.55.git [media] go7007: dubious one-bit signed bitfields Because they're signed, "is_video" and "is_audio" can be 0 and -1 instead of 0 and 1 as intended. It doesn't cause a bug, but it makes Sparse complain: drivers/staging/media/go7007/go7007-priv.h:94:31: error: dubious one-bit signed bitfield drivers/staging/media/go7007/go7007-priv.h:95:31: error: dubious one-bit signed bitfield Signed-off-by: Dan Carpenter Acked-by: Hans Verkuil Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/staging/media/go7007/go7007-priv.h b/drivers/staging/media/go7007/go7007-priv.h index 8bde187e4f90..6e16af720504 100644 --- a/drivers/staging/media/go7007/go7007-priv.h +++ b/drivers/staging/media/go7007/go7007-priv.h @@ -91,8 +91,8 @@ struct go7007_board_info { int num_i2c_devs; struct go_i2c { const char *type; - int is_video:1; - int is_audio:1; + unsigned int is_video:1; + unsigned int is_audio:1; int addr; u32 flags; } i2c_devs[5];