From: Dan Carpenter <error27@gmail.com>
Date: Thu, 22 Apr 2010 09:39:29 +0000 (+0200)
Subject: ocfs2: potential ERR_PTR dereference on error paths
X-Git-Tag: firefly_0821_release~10186^2~1693
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=8cab1cb1cddb0731a0597575389230389ddea882;p=firefly-linux-kernel-4.4.55.git

ocfs2: potential ERR_PTR dereference on error paths

commit 0350cb078f5035716ebdad4ad4709d02fe466a8a upstream.

If "handle" is non null at the end of the function then we assume it's a
valid pointer and pass it to ocfs2_commit_trans();

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
index 0297fb8982b8..4c827d865474 100644
--- a/fs/ocfs2/inode.c
+++ b/fs/ocfs2/inode.c
@@ -559,6 +559,7 @@ static int ocfs2_truncate_for_delete(struct ocfs2_super *osb,
 		handle = ocfs2_start_trans(osb, OCFS2_INODE_UPDATE_CREDITS);
 		if (IS_ERR(handle)) {
 			status = PTR_ERR(handle);
+			handle = NULL;
 			mlog_errno(status);
 			goto out;
 		}