From: Alan Cox Date: Tue, 22 Jul 2008 10:13:51 +0000 (+0100) Subject: keyspan_pda: Use string flip functions X-Git-Tag: firefly_0821_release~19504 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=8dd03a5b2b775b0932c1705dc19298ccda19167d;p=firefly-linux-kernel-4.4.55.git keyspan_pda: Use string flip functions Signed-off-by: Alan Cox Signed-off-by: Greg Kroah-Hartman Signed-off-by: Linus Torvalds --- diff --git a/drivers/usb/serial/keyspan_pda.c b/drivers/usb/serial/keyspan_pda.c index b60012ce4c91..040040a267d9 100644 --- a/drivers/usb/serial/keyspan_pda.c +++ b/drivers/usb/serial/keyspan_pda.c @@ -207,7 +207,6 @@ static void keyspan_pda_rx_interrupt(struct urb *urb) struct usb_serial_port *port = urb->context; struct tty_struct *tty = port->port.tty; unsigned char *data = urb->transfer_buffer; - int i; int retval; int status = urb->status; struct keyspan_pda_private *priv; @@ -235,8 +234,8 @@ static void keyspan_pda_rx_interrupt(struct urb *urb) case 0: /* rest of message is rx data */ if (urb->actual_length) { - for (i = 1; i < urb->actual_length ; ++i) - tty_insert_flip_char(tty, data[i], 0); + tty_insert_flip_string(tty, data + 1, + urb->actual_length - 1); tty_flip_buffer_push(tty); } break;