From: Cedric Venet Date: Fri, 5 Dec 2008 13:37:30 +0000 (+0000) Subject: The use of the construct: X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=8f241b0efb8b6449904cd985f4f7394398970363;p=oota-llvm.git The use of the construct: for(Type1 B = ...;;) { Type2 B ; ... } is bad: code is hard to read and VS VS don't like it (it ignore the second declaration of B). This patch fix the problem in tablegen. Please don't write code like this. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@60590 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/utils/TableGen/LLVMCConfigurationEmitter.cpp b/utils/TableGen/LLVMCConfigurationEmitter.cpp index fc9553ed268..97ea3d68346 100644 --- a/utils/TableGen/LLVMCConfigurationEmitter.cpp +++ b/utils/TableGen/LLVMCConfigurationEmitter.cpp @@ -1548,9 +1548,9 @@ void TypecheckGraph (const RecordVector& EdgeVector, StringMap::iterator IAE = ToolToOutLang.end(); StringMap >::iterator IBE = ToolToInLang.end(); - for (RecordVector::const_iterator B = EdgeVector.begin(), - E = EdgeVector.end(); B != E; ++B) { - const Record* Edge = *B; + for (RecordVector::const_iterator Beg = EdgeVector.begin(), + E = EdgeVector.end(); Beg != E; ++Beg) { + const Record* Edge = *Beg; const std::string& A = Edge->getValueAsString("a"); const std::string& B = Edge->getValueAsString("b"); StringMap::iterator IA = ToolToOutLang.find(A); @@ -1615,9 +1615,9 @@ void EmitEdgeClasses (const RecordVector& EdgeVector, const GlobalOptionDescriptions& OptDescs, std::ostream& O) { int i = 0; - for (RecordVector::const_iterator B = EdgeVector.begin(), - E = EdgeVector.end(); B != E; ++B) { - const Record* Edge = *B; + for (RecordVector::const_iterator Beg = EdgeVector.begin(), + E = EdgeVector.end(); Beg != E; ++Beg) { + const Record* Edge = *Beg; const std::string& B = Edge->getValueAsString("b"); DagInit* Weight = Edge->getValueAsDag("weight"); @@ -1645,9 +1645,9 @@ void EmitPopulateCompilationGraph (const RecordVector& EdgeVector, // Insert edges. int i = 0; - for (RecordVector::const_iterator B = EdgeVector.begin(), - E = EdgeVector.end(); B != E; ++B) { - const Record* Edge = *B; + for (RecordVector::const_iterator Beg = EdgeVector.begin(), + E = EdgeVector.end(); Beg != E; ++Beg) { + const Record* Edge = *Beg; const std::string& A = Edge->getValueAsString("a"); const std::string& B = Edge->getValueAsString("b"); DagInit* Weight = Edge->getValueAsDag("weight"); @@ -1800,10 +1800,10 @@ void FilterNotInGraph (const RecordVector& EdgeVector, // List all tools mentioned in the graph. llvm::StringSet<> ToolsInGraph; - for (RecordVector::const_iterator B = EdgeVector.begin(), - E = EdgeVector.end(); B != E; ++B) { + for (RecordVector::const_iterator Beg = EdgeVector.begin(), + E = EdgeVector.end(); Beg != E; ++Beg) { - const Record* Edge = *B; + const Record* Edge = *Beg; const std::string& A = Edge->getValueAsString("a"); const std::string& B = Edge->getValueAsString("b");