From: Cyrill Gorcunov <gorcunov@openvz.org>
Date: Mon, 5 Apr 2010 16:56:57 +0000 (+0400)
Subject: Staging: hv: Fix up memory leak on HvCleanup
X-Git-Tag: firefly_0821_release~10186^2~1686
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=96f0910dd3e79dcda84daa963ddb435a93025a9d;p=firefly-linux-kernel-4.4.55.git

Staging: hv: Fix up memory leak on HvCleanup

commit fa8ad0257ea256381126ecf447694622216c600f upstream.

Don't assign NULL too early

Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/staging/hv/Hv.c b/drivers/staging/hv/Hv.c
index c2809f2a2ce0..b12237f90db2 100644
--- a/drivers/staging/hv/Hv.c
+++ b/drivers/staging/hv/Hv.c
@@ -306,9 +306,9 @@ void HvCleanup(void)
 	DPRINT_ENTER(VMBUS);
 
 	if (gHvContext.SignalEventBuffer) {
+		kfree(gHvContext.SignalEventBuffer);
 		gHvContext.SignalEventBuffer = NULL;
 		gHvContext.SignalEventParam = NULL;
-		kfree(gHvContext.SignalEventBuffer);
 	}
 
 	if (gHvContext.GuestId == HV_LINUX_GUEST_ID) {