From: Hans Verkuil <hans.verkuil@cisco.com>
Date: Wed, 30 Jan 2013 17:07:38 +0000 (-0300)
Subject: [media] bw-qcam: remove unnecessary qc_reset and qc_setscanmode calls
X-Git-Tag: firefly_0821_release~3680^2~275^2~172
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=971dfc678114d61c07bd6f8ff8380558b6e12d5d;p=firefly-linux-kernel-4.4.55.git

[media] bw-qcam: remove unnecessary qc_reset and qc_setscanmode calls

These are already done elsewhere.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
---

diff --git a/drivers/media/parport/bw-qcam.c b/drivers/media/parport/bw-qcam.c
index d3fe34f14c0d..06231b85e1a9 100644
--- a/drivers/media/parport/bw-qcam.c
+++ b/drivers/media/parport/bw-qcam.c
@@ -421,8 +421,6 @@ static void qc_set(struct qcam *q)
 	int val;
 	int val2;
 
-	qc_reset(q);
-
 	/* Set the brightness.  Yes, this is repetitive, but it works.
 	 * Shorter versions seem to fail subtly.  Feel free to try :-). */
 	/* I think the problem was in qc_command, not here -- bls */
@@ -879,10 +877,8 @@ static int qcam_s_ctrl(struct v4l2_ctrl *ctrl)
 		ret = -EINVAL;
 		break;
 	}
-	if (ret == 0) {
-		qc_setscanmode(qcam);
+	if (ret == 0)
 		qcam->status |= QC_PARAM_CHANGE;
-	}
 	return ret;
 }