From: Colin Cross <ccross@android.com>
Date: Wed, 22 Jun 2011 21:27:37 +0000 (-0700)
Subject: net: ipv4: tcp: Fix crash in tcp_nuke_addr
X-Git-Tag: firefly_0821_release~7613^2~583
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=99e01b39d98cd93ca749cca79272d7eb40cc07b0;p=firefly-linux-kernel-4.4.55.git

net: ipv4: tcp: Fix crash in tcp_nuke_addr

ip_route_output_key can return an ERR_PTR, don't dereference it.

Change-Id: I6b86a451b2bdb33873d79b3cf90c11dbe72bc081
Signed-off-by: Colin Cross <ccross@android.com>
---

diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index d99fd5c91903..0387db527de9 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -3334,7 +3334,7 @@ static int tcp_is_local(struct net *net, __be32 addr) {
 	struct rtable *rt;
 	struct flowi4 fl4 = { .daddr = addr };
 	rt = ip_route_output_key(net, &fl4);
-	if (!rt)
+	if (IS_ERR_OR_NULL(rt))
 		return 0;
 	return rt->dst.dev && (rt->dst.dev->flags & IFF_LOOPBACK);
 }