From: Dale Johannesen Date: Fri, 15 Jan 2010 23:29:29 +0000 (+0000) Subject: Adjust some comments per review. X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=9a23981ecc3549bd7e9dc3b5a6ae228e92dd6ce8;p=oota-llvm.git Adjust some comments per review. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@93580 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp b/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp index 931d66287c7..d710a3f85b2 100644 --- a/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp +++ b/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp @@ -422,11 +422,13 @@ void X86AsmPrinter::printInstructionThroughMCStreamer(const MachineInstr *MI) { printLabel(MI); return; case TargetInstrInfo::DEBUG_VALUE: { + // FIXME: if this is implemented for another target before it goes + // away completely, the common part should be moved into AsmPrinter. if (!VerboseAsm) return; O << '\t' << MAI->getCommentString() << "DEBUG_VALUE: "; unsigned NOps = MI->getNumOperands(); - // cast away const; DIetc do not take const operands for some reason + // cast away const; DIetc do not take const operands for some reason. DIVariable V((MDNode*)(MI->getOperand(NOps-1).getMetadata())); O << V.getName(); O << " <- "; @@ -435,7 +437,7 @@ void X86AsmPrinter::printInstructionThroughMCStreamer(const MachineInstr *MI) { assert(MI->getOperand(0).getType()==MachineOperand::MO_Register); printOperand(MI, 0); } else { - // Frame address. Currently handles ESP or ESP + offset only + // Frame address. Currently handles register +- offset only. assert(MI->getOperand(0).getType()==MachineOperand::MO_Register); assert(MI->getOperand(3).getType()==MachineOperand::MO_Immediate); O << '['; printOperand(MI, 0); O << '+'; printOperand(MI, 3); O << ']';