From: Axel Lin Date: Sat, 31 Aug 2013 11:42:56 +0000 (+0800) Subject: spi: rspi: Add spi_master_get() call to prevent use after free X-Git-Tag: firefly_0821_release~176^2~5480^2~9^2 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=9d3405dbbbd8418a095301d495da65bc3bc5f806;p=firefly-linux-kernel-4.4.55.git spi: rspi: Add spi_master_get() call to prevent use after free In rspi_remove(), current code dereferences rspi after spi_unregister_master(), thus add an extra spi_master_get() call is necessary to prevent use after free. Current code already has an extra spi_master_put() call in rspi_remove(), so this patch just adds a spi_master_get() call rather than a spi_master_get() with spi_master_put() calls. Signed-off-by: Axel Lin Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-rspi.c b/drivers/spi/spi-rspi.c index 00c32320dce8..49ae72a93087 100644 --- a/drivers/spi/spi-rspi.c +++ b/drivers/spi/spi-rspi.c @@ -726,7 +726,7 @@ static void rspi_release_dma(struct rspi_data *rspi) static int rspi_remove(struct platform_device *pdev) { - struct rspi_data *rspi = platform_get_drvdata(pdev); + struct rspi_data *rspi = spi_master_get(platform_get_drvdata(pdev)); spi_unregister_master(rspi->master); rspi_release_dma(rspi);