From: Christopher Dykes <cdykes@fb.com>
Date: Tue, 19 Jul 2016 02:49:24 +0000 (-0700)
Subject: Make sure to return from atomicHashArrayInsertRaceThread
X-Git-Tag: 2016.07.26~32
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=9dbb52ab5c9532002435e1b249c2313bb36570de;p=folly.git

Make sure to return from atomicHashArrayInsertRaceThread

Summary: Because, unfortunately, `pthread_exit` is not marked as noreturn in the pthread library primarily used on Windows, we need to return something to avoid errors.

Reviewed By: yfeldblum

Differential Revision: D3571465

fbshipit-source-id: 4713b2364d6584ae255fb83cd21406fdc33ee299
---

diff --git a/folly/test/AtomicHashMapTest.cpp b/folly/test/AtomicHashMapTest.cpp
index f884b4ed..e62e8386 100644
--- a/folly/test/AtomicHashMapTest.cpp
+++ b/folly/test/AtomicHashMapTest.cpp
@@ -21,6 +21,8 @@
 #include <thread>
 #include <atomic>
 #include <memory>
+
+#include <folly/Assume.h>
 #include <folly/Benchmark.h>
 #include <folly/Conv.h>
 #include <folly/portability/Atomic.h>
@@ -679,6 +681,7 @@ void* atomicHashArrayInsertRaceThread(void* /* j */) {
     }
   }
   pthread_exit((void *) numInserted);
+  folly::assume(false);
 }
 TEST(Ahm, atomic_hash_array_insert_race) {
   AHA* arr = atomicHashArrayInsertRaceArray.get();