From: Chris Lattner Date: Sun, 18 Jan 2009 23:22:07 +0000 (+0000) Subject: Make this a bit more explicit about which cases need the X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=9dd3b610dcb17f88ed52ae03022179bf21e0e132;p=oota-llvm.git Make this a bit more explicit about which cases need the check. No functionality change. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@62474 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Transforms/Utils/SimplifyCFG.cpp b/lib/Transforms/Utils/SimplifyCFG.cpp index 366021e6480..1a0b0b4b66d 100644 --- a/lib/Transforms/Utils/SimplifyCFG.cpp +++ b/lib/Transforms/Utils/SimplifyCFG.cpp @@ -969,14 +969,18 @@ static bool SpeculativelyExecuteBB(BranchInst *BI, BasicBlock *BB1) { default: return false; // Not safe / profitable to hoist. case Instruction::Add: case Instruction::Sub: + // FP arithmetic might trap. Not worth doing for vector ops. + if (I->getType()->isFloatingPoint() || isa(I->getType())) + return false; + break; case Instruction::And: case Instruction::Or: case Instruction::Xor: case Instruction::Shl: case Instruction::LShr: case Instruction::AShr: - if (!I->getOperand(0)->getType()->isInteger()) - // FP arithmetic might trap. Not worth doing for vector ops. + // Don't mess with vector operations. + if (isa(I->getType())) return false; break; // These are all cheap and non-trapping instructions. }