From: Chris Lattner Date: Sat, 17 Feb 2007 06:00:35 +0000 (+0000) Subject: Implement i/n/s constraints correctly. This fixes X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=9ff6ee85fe281c5686e0885eaa0c37ad5378ed52;p=oota-llvm.git Implement i/n/s constraints correctly. This fixes test/CodeGen/PowerPC/2007-02-16-InlineAsmNConstraint.ll git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@34368 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/CodeGen/SelectionDAG/TargetLowering.cpp b/lib/CodeGen/SelectionDAG/TargetLowering.cpp index d389a5a97c0..fd7500f71ef 100644 --- a/lib/CodeGen/SelectionDAG/TargetLowering.cpp +++ b/lib/CodeGen/SelectionDAG/TargetLowering.cpp @@ -1856,12 +1856,26 @@ SDOperand TargetLowering::isOperandValidForConstraint(SDOperand Op, char ConstraintLetter, SelectionDAG &DAG) { switch (ConstraintLetter) { - default: return SDOperand(0,0); + default: break; case 'i': // Simple Integer or Relocatable Constant case 'n': // Simple Integer case 's': // Relocatable Constant - return Op; // FIXME: not right. + // These are okay if the operand is either a global variable address or a + // simple immediate value. If we have one of these, map to the TargetXXX + // version so that the value itself doesn't get selected. + if (ConstantSDNode *C = dyn_cast(Op)) { + // Simple constants are not allowed for 's'. + if (ConstraintLetter != 's') + return DAG.getTargetConstant(C->getValue(), Op.getValueType()); + } + if (GlobalAddressSDNode *GA = dyn_cast(Op)) { + if (ConstraintLetter != 'n') + return DAG.getTargetGlobalAddress(GA->getGlobal(), Op.getValueType(), + GA->getOffset()); + } + break; } + return SDOperand(0,0); } std::vector TargetLowering::