From: Dan Carpenter <error27@gmail.com>
Date: Thu, 9 Apr 2009 16:07:10 +0000 (+0200)
Subject: ext2: missing unlock in ext2_quota_write()
X-Git-Tag: firefly_0821_release~14314^2
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=a069e9cee1dba2f847839d325f46ce6976ed1b76;p=firefly-linux-kernel-4.4.55.git

ext2: missing unlock in ext2_quota_write()

The inode->i_mutex should be unlocked.

Found by smatch (http://repo.or.cz/w/smatch.git).  Compile tested.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
---

diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index f983225266dc..5c4afe652245 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -1395,8 +1395,10 @@ static ssize_t ext2_quota_write(struct super_block *sb, int type,
 		blk++;
 	}
 out:
-	if (len == towrite)
+	if (len == towrite) {
+		mutex_unlock(&inode->i_mutex);
 		return err;
+	}
 	if (inode->i_size < off+len-towrite)
 		i_size_write(inode, off+len-towrite);
 	inode->i_version++;