From: Punit Vara Date: Wed, 14 Oct 2015 18:25:53 +0000 (+0530) Subject: Staging: rtl8712: Use ether_addr_equal() over memcmp() X-Git-Tag: firefly_0821_release~176^2~802^2~603 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=a1b42bef0a4bfea3b6679ef05e9b26eebe0d0682;p=firefly-linux-kernel-4.4.55.git Staging: rtl8712: Use ether_addr_equal() over memcmp() This patch is to the rtl871x_ioctl_linux.c file that fixes up following warning reported by checkpatch.pl : -Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp() bssid and pnetwork->network.MacAddress both are 6 byte array which aligned with u16 Signed-off-by: Punit Vara Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c index 5618dba8e05f..e5a52a90feeb 100644 --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c @@ -1981,7 +1981,7 @@ static int r871x_get_ap_info(struct net_device *dev, return -EINVAL; } netdev_info(dev, "r8712u: BSSID:%pM\n", bssid); - if (!memcmp(bssid, pnetwork->network.MacAddress, ETH_ALEN)) { + if (ether_addr_equal(bssid, pnetwork->network.MacAddress)) { /* BSSID match, then check if supporting wpa/wpa2 */ pbuf = r8712_get_wpa_ie(&pnetwork->network.IEs[12], &wpa_ielen, pnetwork->network.IELength-12);