From: Dan Carpenter Date: Tue, 21 Jul 2015 08:57:36 +0000 (+0300) Subject: ASoC: sti: error handling bug in sti_uniperiph_cpu_dai_of() X-Git-Tag: firefly_0821_release~176^2~1082^2~13^2~5^4~4 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=a4642e99694a912b32952317e8f4c253ed6be4a9;p=firefly-linux-kernel-4.4.55.git ASoC: sti: error handling bug in sti_uniperiph_cpu_dai_of() There is a stray '!' which means the condition is never true. Fixes: f3bd847eb0a7 ('ASoC: sti: Add uniperipheral dai driver') Signed-off-by: Dan Carpenter Signed-off-by: Mark Brown --- diff --git a/sound/soc/sti/sti_uniperif.c b/sound/soc/sti/sti_uniperif.c index 51f745c56c7f..dffabf3ba9fb 100644 --- a/sound/soc/sti/sti_uniperif.c +++ b/sound/soc/sti/sti_uniperif.c @@ -175,7 +175,7 @@ static int sti_uniperiph_cpu_dai_of(struct device_node *node, UNIPERIF_FIFO_DATA_OFFSET(uni); uni->irq = platform_get_irq(priv->pdev, 0); - if (!uni->irq < 0) { + if (uni->irq < 0) { dev_err(dev, "Failed to get IRQ resource"); return -ENXIO; }