From: Arnd Bergmann Date: Sun, 27 Sep 2015 20:45:47 +0000 (-0400) Subject: staging/lustre: partially use time64_t for capa expiry X-Git-Tag: firefly_0821_release~176^2~802^2~1460 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=a6c8746d54047640e71572d3f48f0bf5708bc92f;p=firefly-linux-kernel-4.4.55.git staging/lustre: partially use time64_t for capa expiry Here, we actually have a problem in 2038 or at the latest in 2106 when the lc_expiry variable on the wire protocol overflows, including on 64-bit architectures. Now that the actual code was removed, only on-the wire structure is left so we add in a y2038 warning to remind whoever gets to implement it again about this problem. Signed-off-by: Arnd Bergmann Signed-off-by: Oleg Drokin Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h index 057fa19186f0..3ac1de352296 100644 --- a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h +++ b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h @@ -3478,6 +3478,7 @@ struct lustre_capa { __u32 lc_flags; /** HMAC algorithm & flags */ __u32 lc_keyid; /** key# used for the capability */ __u32 lc_timeout; /** capa timeout value (sec) */ +/* FIXME: y2038 time_t overflow: */ __u32 lc_expiry; /** expiry time (sec) */ __u8 lc_hmac[CAPA_HMAC_MAX_LEN]; /** HMAC */ } __attribute__((packed));