From: Guenter Roeck Date: Tue, 13 Nov 2012 21:27:19 +0000 (+0100) Subject: i2c-mux-pinctrl: Fix probe error path X-Git-Tag: firefly_0821_release~3680^2~1641^2 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=aa1e3e81e75ceb3d977c3292cefafcd5179eb8b8;p=firefly-linux-kernel-4.4.55.git i2c-mux-pinctrl: Fix probe error path When allocating the memory for i2c busses, the code checked the wrong variable and thus never detected if there was a memory error. Signed-off-by: Guenter Roeck Cc: stable@vger.kernel.org Signed-off-by: Jean Delvare --- diff --git a/drivers/i2c/muxes/i2c-mux-pinctrl.c b/drivers/i2c/muxes/i2c-mux-pinctrl.c index 5f097f309b9f..7fa5b24b16db 100644 --- a/drivers/i2c/muxes/i2c-mux-pinctrl.c +++ b/drivers/i2c/muxes/i2c-mux-pinctrl.c @@ -169,7 +169,7 @@ static int __devinit i2c_mux_pinctrl_probe(struct platform_device *pdev) mux->busses = devm_kzalloc(&pdev->dev, sizeof(mux->busses) * mux->pdata->bus_count, GFP_KERNEL); - if (!mux->states) { + if (!mux->busses) { dev_err(&pdev->dev, "Cannot allocate busses\n"); ret = -ENOMEM; goto err;