From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: Sun, 4 Mar 2012 17:26:15 +0000 (-0800)
Subject: Input: cyttsp - remove useless checks in cyttsp_probe()
X-Git-Tag: firefly_0821_release~176^2~541^2~352^2~18
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=aaa60fa7ac66ede814f7ad37a2b3a07b4f784756;p=firefly-linux-kernel-4.4.55.git

Input: cyttsp - remove useless checks in cyttsp_probe()

This fixes reference-before-check problem; there is no reason to check
if caller passed NULL dev or bus_ops as it is done only by bus-specific
drivers which already do the right thing.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---

diff --git a/drivers/input/touchscreen/cyttsp_core.c b/drivers/input/touchscreen/cyttsp_core.c
index 8be22479b41c..f030d9ec795d 100644
--- a/drivers/input/touchscreen/cyttsp_core.c
+++ b/drivers/input/touchscreen/cyttsp_core.c
@@ -523,7 +523,7 @@ struct cyttsp *cyttsp_probe(const struct cyttsp_bus_ops *bus_ops,
 	struct input_dev *input_dev;
 	int error;
 
-	if (!dev || !bus_ops || !pdata || !pdata->name || irq <= 0) {
+	if (!pdata || !pdata->name || irq <= 0) {
 		error = -EINVAL;
 		goto err_out;
 	}