From: Daniel Vetter Date: Mon, 23 Nov 2015 09:32:49 +0000 (+0100) Subject: drm/gma500: Use correct unref in the gem bo create function X-Git-Tag: firefly_0821_release~176^2~475^2~365 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=ab3b00b70e5552d6060118952312f9c201218dc4;p=firefly-linux-kernel-4.4.55.git drm/gma500: Use correct unref in the gem bo create function commit d3e376f52d095103ca51dbda4d6ff8aaf488f98f upstream. This is called without dev->struct_mutex held, we need to use the _unlocked variant. Never caught in the wild since you'd need an evil userspace which races a gem_close ioctl call with the in-progress open. Cc: Patrik Jakobsson Acked-by: Patrik Jakobsson Signed-off-by: Daniel Vetter Link: http://patchwork.freedesktop.org/patch/msgid/1448271183-20523-17-git-send-email-daniel.vetter@ffwll.ch Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/gpu/drm/gma500/gem.c b/drivers/gpu/drm/gma500/gem.c index c707fa6fca85..e3bdc8b1c32c 100644 --- a/drivers/gpu/drm/gma500/gem.c +++ b/drivers/gpu/drm/gma500/gem.c @@ -130,7 +130,7 @@ int psb_gem_create(struct drm_file *file, struct drm_device *dev, u64 size, return ret; } /* We have the initial and handle reference but need only one now */ - drm_gem_object_unreference(&r->gem); + drm_gem_object_unreference_unlocked(&r->gem); *handlep = handle; return 0; }