From: Philipp Zabel
Date: Thu, 20 Aug 2015 07:35:43 +0000 (-0300)
Subject: [media] tc358743: only queue subdev notifications if devnode is set
X-Git-Tag: firefly_0821_release~176^2~795^2~150
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=abeaca0ff5666a1cd7460304e619e4c6a486ea04;p=firefly-linux-kernel-4.4.55.git
[media] tc358743: only queue subdev notifications if devnode is set
Hardware interrupts are enabled in the probe function, before the subdev
is registered to its v4l2_device. Until v4l2_device_register_subdev_node
is called, sd->devnode is NULL and v4l2_subdev_notify_event must not be
called.
Signed-off-by: Philipp Zabel
Signed-off-by: Mauro Carvalho Chehab
---
diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
index 7a6fdecc7215..526d30745a19 100644
--- a/drivers/media/i2c/tc358743.c
+++ b/drivers/media/i2c/tc358743.c
@@ -870,7 +870,8 @@ static void tc358743_format_change(struct v4l2_subdev *sd)
&timings, false);
}
- v4l2_subdev_notify_event(sd, &tc358743_ev_fmt);
+ if (sd->devnode)
+ v4l2_subdev_notify_event(sd, &tc358743_ev_fmt);
}
static void tc358743_init_interrupts(struct v4l2_subdev *sd)