From: Mauro Carvalho Chehab Date: Tue, 28 Apr 2015 11:48:15 +0000 (-0300) Subject: [media] am437x-vpfe: really update the vpfe_ccdc_update_raw_params data X-Git-Tag: firefly_0821_release~176^2~795^2~982 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=adf98ffe8055107e75e9e914c1733e97952a6f9a;p=firefly-linux-kernel-4.4.55.git [media] am437x-vpfe: really update the vpfe_ccdc_update_raw_params data drivers/media/platform/am437x/am437x-vpfe.c: In function 'vpfe_ccdc_update_raw_params': drivers/media/platform/am437x/am437x-vpfe.c:430:38: warning: variable 'config_params' set but not used [-Wunused-but-set-variable] struct vpfe_ccdc_config_params_raw *config_params = ^ vpfe_ccdc_update_raw_params() is supposed to update the raw params at ccdc. However, it is just creating a local var and changing it. Compile-tested only. Cc: Benoit Parrot Signed-off-by: Mauro Carvalho Chehab Acked-by: Lad, Prabhakar Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/am437x/am437x-vpfe.c b/drivers/media/platform/am437x/am437x-vpfe.c index a30cc2f7e4f1..9c037ac10e10 100644 --- a/drivers/media/platform/am437x/am437x-vpfe.c +++ b/drivers/media/platform/am437x/am437x-vpfe.c @@ -430,7 +430,7 @@ vpfe_ccdc_update_raw_params(struct vpfe_ccdc *ccdc, struct vpfe_ccdc_config_params_raw *config_params = &ccdc->ccdc_cfg.bayer.config_params; - config_params = raw_params; + *config_params = *raw_params; } /*