From: Jim Cromie <jim.cromie@gmail.com>
Date: Mon, 19 Dec 2011 22:12:34 +0000 (-0500)
Subject: dynamic_debug: pr_err() call should not depend upon verbosity
X-Git-Tag: firefly_0821_release~3680^2~3348^2~70
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=ae27f86a21eb9a9e005f06b126eb88662ba4f940;p=firefly-linux-kernel-4.4.55.git

dynamic_debug: pr_err() call should not depend upon verbosity

Issue keyword/parsing errors even w/o verbose set;
uncover otherwize mysterious non-functionality.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Jason Baron <jbaron@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 6fc8622f0a83..d232025cb85c 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -322,8 +322,7 @@ static int ddebug_parse_query(char *words[], int nwords,
 				query->last_lineno = query->first_lineno;
 			}
 		} else {
-			if (verbose)
-				pr_err("unknown keyword \"%s\"\n", words[i]);
+			pr_err("unknown keyword \"%s\"\n", words[i]);
 			return -EINVAL;
 		}
 	}